vision: Got empty response when requests are gzipped. #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a workaround to the remaining samples for an issue where requests over a certain size will "succeed" but return an empty response from the vision API when gzipped. The workaround is to disable gzip compression. Most images should be in compressed formats anyway, so it's not like we are saving much bandwidth with it.
googlebot
added
the
cla: yes
|
LGTM |
jerjou
approved these changes
Sep 19, 2016
minherz
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Shabirmean
pushed a commit
that referenced
this pull request
Nov 11, 2022
…14.6 (#341) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.14.3` -> `2.14.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.14.6`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2146-httpsgithubcomgoogleapisjava-bigquerycomparev2145v2146-2022-08-12) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.5...v2.14.6) ##### Dependencies - update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.9.2 ([#​2221](https://togithub.com/googleapis/java-bigquery/issues/2221)) ([3292cdd](https://togithub.com/googleapis/java-bigquery/commit/3292cddeec7c83fa198a96d80a35c13b003a26c8)) ### [`v2.14.5`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2145-httpsgithubcomgoogleapisjava-bigquerycomparev2144v2145-2022-08-12) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.4...v2.14.5) ##### Dependencies - update dependency com.google.apis:google-api-services-bigquery to v2-rev20220806-2.0.0 ([#​2223](https://togithub.com/googleapis/java-bigquery/issues/2223)) ([05d1de1](https://togithub.com/googleapis/java-bigquery/commit/05d1de19488c45ceb202824d9ce2ae0fd290d930)) ### [`v2.14.4`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2144-httpsgithubcomgoogleapisjava-bigquerycomparev2143v2144-2022-08-08) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.3...v2.14.4) ##### Dependencies - update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#​2213](https://togithub.com/googleapis/java-bigquery/issues/2213)) ([a293ab5](https://togithub.com/googleapis/java-bigquery/commit/a293ab56c5455cef8b9731784ddd78cc6162dca8)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-contact-center-insights). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTAuNCIsInVwZGF0ZWRJblZlciI6IjMyLjE1OC4wIn0=-->
9 tasks
9 tasks
charlieyu1996
pushed a commit
that referenced
this pull request
Nov 11, 2022
…4.0 (#341) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `13.3.0` -> `13.4.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datacatalog).
Shabirmean
pushed a commit
that referenced
this pull request
Nov 11, 2022
…14.6 (#341) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.14.3` -> `2.14.6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.14.6`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2146-httpsgithubcomgoogleapisjava-bigquerycomparev2145v2146-2022-08-12) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.5...v2.14.6) ##### Dependencies - update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.9.2 ([#​2221](https://togithub.com/googleapis/java-bigquery/issues/2221)) ([3292cdd](https://togithub.com/googleapis/java-bigquery/commit/3292cddeec7c83fa198a96d80a35c13b003a26c8)) ### [`v2.14.5`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2145-httpsgithubcomgoogleapisjava-bigquerycomparev2144v2145-2022-08-12) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.4...v2.14.5) ##### Dependencies - update dependency com.google.apis:google-api-services-bigquery to v2-rev20220806-2.0.0 ([#​2223](https://togithub.com/googleapis/java-bigquery/issues/2223)) ([05d1de1](https://togithub.com/googleapis/java-bigquery/commit/05d1de19488c45ceb202824d9ce2ae0fd290d930)) ### [`v2.14.4`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2144-httpsgithubcomgoogleapisjava-bigquerycomparev2143v2144-2022-08-08) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.14.3...v2.14.4) ##### Dependencies - update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#​2213](https://togithub.com/googleapis/java-bigquery/issues/2213)) ([a293ab5](https://togithub.com/googleapis/java-bigquery/commit/a293ab56c5455cef8b9731784ddd78cc6162dca8)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-contact-center-insights). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTAuNCIsInVwZGF0ZWRJblZlciI6IjMyLjE1OC4wIn0=-->
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
…4.0 (#341) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `16.3.0` -> `16.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
…4.0 (#341) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `16.3.0` -> `16.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).
Shabirmean
pushed a commit
that referenced
this pull request
Nov 17, 2022
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
anguillanneuf
pushed a commit
that referenced
this pull request
Dec 5, 2022
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workaround to the remaining samples for an issue where
requests over a certain size will "succeed" but return an empty response
from the vision API when gzipped.
The workaround is to disable gzip compression. Most images should be in
compressed formats anyway, so it's not like we are saving much bandwidth
with it.